fix(db): fix namings in DBDeleteOldOverviews function

Ref: SRX-0Q0FWU
freiheit-com · Oct 8, 2024 · b007300 · b007300
1 parent dbfa856
commit b007300
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/charts/kuberpult/templates/cd-service.yaml b/charts/kuberpult/templates/cd-service.yaml
@@ -165,7 +165,7 @@ spec:
           value: {{ .Values.git.webUrl | quote }}
 {{- if .Values.datadogTracing.enabled }}
         - name: KUBERPULT_CACHE_TTL_HOURS
-          value: {{ default 24 .Values.cd.cacheTtlHours }}
+          value: {{ .Values.cd.cacheTtlHours }}
         - name: DD_AGENT_HOST
           valueFrom:
             fieldRef:

diff --git a/pkg/db/overview.go b/pkg/db/overview.go
@@ -316,7 +316,7 @@ func (h *DBHandler) IsOverviewEmpty(overviewResp *api.GetOverviewResponse) bool
 	return false
 }
 
-func (h *DBHandler) DBDeleteOldOverviews(ctx context.Context, tx *sql.Tx, numberOfToKeepOverviews uint64, timeThreshold time.Time) error {
+func (h *DBHandler) DBDeleteOldOverviews(ctx context.Context, tx *sql.Tx, numberOfOverviewsToKeep uint64, timeThreshold time.Time) error {
 	span, _ := tracer.StartSpanFromContext(ctx, "DBDeleteOldOverviews")
 	defer span.Finish()
 
@@ -339,10 +339,12 @@ AND eslversion NOT IN (
 );
 `)
 	span.SetTag("query", deleteQuery)
+	span.SetTag("numberOfOverviewsToKeep", numberOfOverviewsToKeep)
+	span.SetTag("timeThreshold", timeThreshold)
 	_, err := tx.Exec(
 		deleteQuery,
 		timeThreshold.UTC(),
-		numberOfToKeepOverviews,
+		numberOfOverviewsToKeep,
 	)
 	if err != nil {
 		return fmt.Errorf("DBDeleteOldOverviews error executing query: %w", err)