Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can only add a single lock deletion to Planned Actions shopping cart #1049

Open
ssp opened this issue Oct 23, 2023 · 3 comments
Open

Can only add a single lock deletion to Planned Actions shopping cart #1049

ssp opened this issue Oct 23, 2023 · 3 comments
Labels
ui/ux

Comments

@ssp
Copy link
Contributor

ssp commented Oct 23, 2023

Reproduce

  1. have some service locks in place
  2. press the delete button for one of them → it will appear in the Planned Actions shopping cat
  3. press the delete button for another one of them

Expected

The second lock deletion also appears in the shopping cart.

Actual

The trash can icon button remains highlighted and nothing else happens.

Bildschirmaufnahme.2023-10-23.um.19.17.23.mov
@sven-urbanski-freiheit-com
Copy link
Contributor

Thanks for the detailed description. I can reproduce it.

Workaround: Delete one lock at a time.

Deveveloper-Note: This seems to be related to the "delete them all" button, as this button does not seem to have the same (non-) response as the delete lock button.

@ssp ssp mentioned this issue Dec 1, 2023
Closed
Merged
bjoern-michaelsen-freiheit added a commit that referenced this issue Jan 5, 2024
@bjoern-michaelsen-freiheit
fix: unable to queue lock removal for different apps (SRX-SSGFKY)
1a70e83 
- Duplicate check now considers app lock removal actions for different applications to be different
- add basic unittests for all the duplicate checks

Reference: #1188
Reference: #1049
bjoern-michaelsen-freiheit added a commit that referenced this issue Jan 5, 2024
@bjoern-michaelsen-freiheit
fix: unable to queue lock removal for different apps (SRX-SSGFKY)
0fcea38 
- Duplicate check now considers app lock removal actions for different applications to be different
- add basic unittests for all the duplicate checks

Reference: #1188
Reference: #1049
bjoern-michaelsen-freiheit added a commit that referenced this issue Jan 8, 2024
@bjoern-michaelsen-freiheit
fix: unable to queue lock removal for different apps (SRX-SSGFKY) (#1266
9ba2bec 
)

- Duplicate check now considers app lock removal actions for different
applications to be different
- add basic unittests for all the duplicate checks

Reference: #1188
Reference: #1049
@sven-urbanski-freiheit-com
Copy link
Contributor

Ref: SRX-FFMDKH

@miguel-crespo-fdc
Copy link
Contributor

#1981

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
ui/ux
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@ssp @sven-urbanski-freiheit-com @bjoern-michaelsen-freiheit @miguel-crespo-fdc