Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not consider the overview cache multiple times in a releasetrain #1980

Merged
merged 18 commits into from
Sep 25, 2024

Conversation

sven-urbanski-freiheit-com
Copy link
Contributor

@sven-urbanski-freiheit-com sven-urbanski-freiheit-com commented Sep 24, 2024

This is a performance improvement that solves 2 issues with the overview cache:

  1. It reduces the amount of times we write the overview in a release train from n=number of apps to 1 per env. The 1 write contains multiple changed apps.
  2. When creating a new app or when undeploying, it does not force a recalculation of the whole overview, but instead only updates the app.

Further cases that also force a complete recalculation of the overview cache (like creating a new environment) are not handled in this PR.

Note that some functions like CalculateWarnings had to be moved to another module but were not changed.

Ref: SRX-4WQBET

@sven-urbanski-freiheit-com sven-urbanski-freiheit-com requested a review from a team as a code owner September 24, 2024 12:53
@sven-urbanski-freiheit-com sven-urbanski-freiheit-com marked this pull request as draft September 24, 2024 13:21
@sven-urbanski-freiheit-com sven-urbanski-freiheit-com marked this pull request as ready for review September 25, 2024 11:34
services/cd-service/pkg/repository/repository.go Outdated Show resolved Hide resolved
services/cd-service/pkg/repository/repository.go Outdated Show resolved Hide resolved
services/cd-service/pkg/repository/repository.go Outdated Show resolved Hide resolved
services/cd-service/pkg/repository/transformer.go Outdated Show resolved Hide resolved
@sven-urbanski-freiheit-com sven-urbanski-freiheit-com merged commit f83175a into main Sep 25, 2024
17 checks passed
@sven-urbanski-freiheit-com sven-urbanski-freiheit-com deleted the su-releasetrain-overview branch September 25, 2024 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants