fix(db): Do not write argo apps if disabled #1989
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While the helm parameter argocd.generateFiles=false technically worked, it would still request a lot of data that is not necessary. With this change, we reduce the number of queries to the database. Ref: SRX-YNEAHU
sven-urbanski-freiheit-com
force-pushed
the
su-fix-argo-generate
branch
from
1080ce1 to
0e07940
Compare
ahmed-nour-fdc
approved these changes
Sep 27, 2024
|
Could you move the check to before to before the span is opened? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While the helm parameter argocd.generateFiles=false technically worked, it would still request a lot of data that is not necessary. With this change, we reduce the number of queries to the database for the case argocd.generateFiles=false.
Ref: SRX-YNEAHU