Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(rollout-service): Adapt rollout service to get information from the GetAppDetails endpoint #2041

Merged
merged 28 commits into from
Oct 17, 2024
Merged

chore(rollout-service): Adapt rollout service to get information from the GetAppDetails endpoint #2041

merged 28 commits into from
Oct 17, 2024

Conversation

miguel-crespo-fdc
Copy link
Contributor

@miguel-crespo-fdc miguel-crespo-fdc commented Oct 14, 2024 •
edited
Loading

Important notes:

  • The rollout service no longer listens for to the stream overview endpoint. It now now listens to the GetChangedApps endpoint, that gets triggered when there is some change to any app, or when an environment is edited
  • The rollout service still makes a request to the overview service to obtain the overview. This is done because there is important environment data there.
  • The rollout service functionality should remain UNCHANGED.
    Ref: SRX-FIC65Q

@miguel-crespo-fdc miguel-crespo-fdc marked this pull request as ready for review October 14, 2024 17:08
@miguel-crespo-fdc miguel-crespo-fdc requested a review from a team as a code owner October 14, 2024 17:08
@miguel-crespo-fdc miguel-crespo-fdc changed the title feat(rollout-service): Adapt rollout service to get information from the GetAppDetails endpoint chore(rollout-service): Adapt rollout service to get information from the GetAppDetails endpoint Oct 14, 2024
hannesg
hannesg previously requested changes Oct 16, 2024
View reviewed changes
services/cd-service/pkg/notify/notify.go Show resolved Hide resolved
services/cd-service/pkg/notify/notify.go Outdated Show resolved Hide resolved
services/rollout-service/pkg/versions/versions.go Outdated Show resolved Hide resolved
@sven-urbanski-freiheit-com sven-urbanski-freiheit-com dismissed hannesg’s stale review October 17, 2024 13:48

Hannes is not available today and we solved all issues that he mentioned

@miguel-crespo-fdc miguel-crespo-fdc merged commit c9db634 into main Oct 17, 2024
17 checks passed
@miguel-crespo-fdc miguel-crespo-fdc deleted the mc/new-endpoint-rollout branch October 17, 2024 13:59
@hannesg hannesg mentioned this pull request Nov 27, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sven-urbanski-freiheit-com sven-urbanski-freiheit-com sven-urbanski-freiheit-com approved these changes

@hannesg hannesg hannesg left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@miguel-crespo-fdc @hannesg @sven-urbanski-freiheit-com