Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(db): fixed select query that ignored eslversions with deleted flag #2053

Merged
merged 21 commits into from
Oct 21, 2024

Conversation

diogo-nogueira-freiheit
Copy link
Contributor

@diogo-nogueira-freiheit diogo-nogueira-freiheit commented Oct 17, 2024

In the DeleteEnvFromApp a query was made which selected the most recent eslversions for each release of the app.
This query ignored rows that has the deleted flag set to true. When the transformer later updated each release if the latest eslversion was deleted then an error would occur.

This query was fixed and, in the process, altered to be more efficient.

Ref: SRX-9MM6SC

@diogo-nogueira-freiheit diogo-nogueira-freiheit requested a review from a team as a code owner October 17, 2024 14:08
@diogo-nogueira-freiheit diogo-nogueira-freiheit enabled auto-merge (squash) October 17, 2024 16:50
@diogo-nogueira-freiheit diogo-nogueira-freiheit merged commit 51d74ae into main Oct 21, 2024
17 checks passed
@diogo-nogueira-freiheit diogo-nogueira-freiheit deleted the dn/double_commits branch October 21, 2024 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants