Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cd-service): removed revision parsing from transaction. #2149

Merged
merged 2 commits into from
Nov 29, 2024

Conversation

diogo-nogueira-freiheit
Copy link
Contributor

@diogo-nogueira-freiheit diogo-nogueira-freiheit commented Nov 29, 2024

The cd-service was parsing the git revision inside a transaction. This meant that if the operation failed we had opened a connection to the database for no reason.

This PR moves this operation outside of the transaction.

Ref: SRX-0F9ZN3

@diogo-nogueira-freiheit diogo-nogueira-freiheit requested a review from a team as a code owner November 29, 2024 13:41
@diogo-nogueira-freiheit diogo-nogueira-freiheit enabled auto-merge (squash) November 29, 2024 13:49
@diogo-nogueira-freiheit diogo-nogueira-freiheit merged commit d99dd51 into main Nov 29, 2024
17 checks passed
@diogo-nogueira-freiheit diogo-nogueira-freiheit deleted the dn/remove_parsing_from_transaction branch November 29, 2024 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants