fix(cd-service): improve get app details deployments #2164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AminSlk
approved these changes
Dec 10, 2024
diogo-nogueira-freiheit
deleted the
dn/improve_get_app_details_deployments
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
GetAppDetailsendpoint collects information about the deployments of an app.One of these is the latest queued version. Currently the endpoint would evaluate one deployment at a time and, when it was decided to be a valid deployment, the database would be queried for this deployment's latest queued version.
This PR queries the database for all latest deployment attempts. Then when analyzing each deployment it just pulls from this information cached in a map.
This might slow down
GetAppDetailsrequests that have no current deployments (since before we would not query the queued versions for invalid deployments). This will translate in improved performance. And in most cases, most apps will have deploymentsRef: SRX-016Y9E