fix: move custom migrations to manifest-export #2167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sven-urbanski-freiheit-com
force-pushed
the
su-migrate-migrations-export-svc
branch
from
5aeb4f4 to
87806f0
Compare
AminSlk
reviewed
Dec 12, 2024
services/manifest-repo-export-service/pkg/migrations/migration.go
Outdated
Show resolved
Hide resolved
sven-urbanski-freiheit-com
force-pushed
the
su-migrate-migrations-export-svc
branch
from
d38bfad to
08f811e
Compare
By "custom migrations" we mean those db migrations that can not be solved by plain SQL, so they are implemented in go. This provides the basic setup to move the custom migrations to the manifest-export-service. * It creates a new endpoint to accept migrations, however the endpoint is not called yet. * It provides the setup like reading/writing to the custom_migration_cutoff table However, this change does not include actually moving the migrations from cd- to export-service. This will be done in a separate PR. Ref: SRX-V6RVYF
sven-urbanski-freiheit-com
force-pushed
the
su-migrate-migrations-export-svc
branch
from
9400478 to
766f506
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By "custom migrations" we mean those db migrations that can not be solved by plain SQL, so they are implemented in go.
This provides the basic setup to move the custom migrations to the manifest-export-service.
However, this change does not include actually moving the migrations from cd- to export-service. This will be done in a separate PR.
Ref: SRX-V6RVYF