Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add jsx-dev-runtime and jsx-runtime types, JSX namespace from Preact #345

Merged
merged 2 commits into from
May 26, 2022
Merged

Add jsx-dev-runtime and jsx-runtime types, JSX namespace from Preact #345

merged 2 commits into from
May 26, 2022

Conversation

zheksoon
Copy link
Contributor

Hello,

I've noticed that Parcel with Typescript doesn't recognises fre's JSX Typescript types, making using it hard to impossible.

My attempt to fix this is:

  1. Add jsx-dev-runtime.js to make Parcel happy at dev mode
  2. Add TS types from the issus jsx-runtime types missing? #239 as jsx-runtime.d.ts
  3. Copy almost the whole JSX namespace from Preact to get rid of JSX.IntrinsicElements error.

Hope this will be useful!

Screen Shot 2022-05-27 at 00 12 15

Screen Shot 2022-05-27 at 00 12 48

@yisar yisar merged commit 2827fa3 into frejs:master May 26, 2022
@yisar
Copy link
Collaborator

yisar commented May 26, 2022

Thank u very much !! It is great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zheksoon @yisar @eugene-daragan-pandadoc