-
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for similar waste types with different API IDs #1267
Conversation
When attempting to run the `updateContentCommand` while building the development container, it returned an error with git as cause. The log stated that the directory was not marked safe, so now it does that before the `updateContentCommand`.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
c81a352
to
96591d5
Compare
Hi @frenck, I (should) have resolved all the issues with CI. Can you take a look? I like the idea of having strict coding guidelines enforced with these typing rules and test coverage. However, if I could make a suggestion it would be to loosen them in some cases. For the |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1267 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 3 3
Lines 95 100 +5
Branches 15 12 -3
=========================================
+ Hits 95 100 +5 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
However, if I could make a suggestion it would be to loosen them in some cases.
Sorry... I strongly disagree very much. Don't know what else to say.
Left a few review comments and the CI is also failing (which is odd? As ruff is run in pre-commit... not sure how you manage to make a commit that passes it).
../Frenck
96591d5
to
95481e9
Compare
Processed your review comments. Let me know if I should drop the first commit with the changes to the dev container file. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @EyeDevelop 👍
../Frenck
Proposed Changes
This PR adds a fall-through method to the
WasteType
enum. The Twente Milieu API might return a waste type that is almost the same as one already defined in the enum.Hengelo now has pick-up points for packaging and paper for high-density living. For the packaging, they created a new waste type. However, it is still packaging. This change now maps the 'odd' waste type returned from the API to the packages value in the enum.
Please let me know what you think!
Related Issues
#1265