Fix results screen fetching more scores twice #1176
GitHub Actions / Test Results (Windows, SingleThread)
failed
Jul 25, 2024 in 1s
10255 passed, 3 failed and 74 skipped
❌ TestResults-Windows-SingleThread.trx
10332 tests were completed in 2410s with 10255 passed, 3 failed and 74 skipped.
| Test suite | Passed | Failed | Skipped | Time |
|---|---|---|---|---|
| osu.Game.Tests.Visual.Gameplay.TestSceneLeadIn | 32✅ | 2❌ | 6s | |
| osu.Game.Tests.Visual.Multiplayer.TestSceneMultiSpectatorScreen | 43✅ | 1❌ | 42s |
❌ osu.Game.Tests.Visual.Gameplay.TestSceneLeadIn
✅ TestConstructor
✅ TestConstructor
✅ TestLeadInProducesCorrectStartTime(1000,0)
✅ TestLeadInProducesCorrectStartTime(1000,0)
✅ TestLeadInProducesCorrectStartTime(10000,-7830.0d)
✅ TestLeadInProducesCorrectStartTime(10000,-7830.0d)
✅ TestLeadInProducesCorrectStartTime(2000,0)
✅ TestLeadInProducesCorrectStartTime(2000,0)
✅ TestLeadInProducesCorrectStartTime(3000,-830.0d)
✅ TestLeadInProducesCorrectStartTime(3000,-830.0d)
✅ TestStoryboardProducesCorrectStartTimeFadeInAfterOtherEvents(-1000,-1000,False)
✅ TestStoryboardProducesCorrectStartTimeFadeInAfterOtherEvents(-1000,-1000,False)
✅ TestStoryboardProducesCorrectStartTimeFadeInAfterOtherEvents(-1000,-1000,True)
✅ TestStoryboardProducesCorrectStartTimeFadeInAfterOtherEvents(-1000,-1000,True)
✅ TestStoryboardProducesCorrectStartTimeFadeInAfterOtherEvents(-10000,-10000,False)
✅ TestStoryboardProducesCorrectStartTimeFadeInAfterOtherEvents(-10000,-10000,False)
✅ TestStoryboardProducesCorrectStartTimeFadeInAfterOtherEvents(-10000,-10000,True)
❌ TestStoryboardProducesCorrectStartTimeFadeInAfterOtherEvents(-10000,-10000,True)
check first frame time: Expected: -10000.0d +/- 100.0d
But was: -9624.2255000000005d
Off by: -375.77449999999953d
✅ TestStoryboardProducesCorrectStartTimeFadeInAfterOtherEvents(0,0,False)
✅ TestStoryboardProducesCorrectStartTimeFadeInAfterOtherEvents(0,0,False)
✅ TestStoryboardProducesCorrectStartTimeFadeInAfterOtherEvents(0,0,True)
✅ TestStoryboardProducesCorrectStartTimeFadeInAfterOtherEvents(0,0,True)
✅ TestStoryboardProducesCorrectStartTimeFadeInAfterOtherEvents(1000,0,False)
❌ TestStoryboardProducesCorrectStartTimeFadeInAfterOtherEvents(1000,0,False)
check first frame time: Expected: 0.0d +/- 100.0d
But was: 225.21689999999998d
Off by: -225.21689999999998d
✅ TestStoryboardProducesCorrectStartTimeFadeInAfterOtherEvents(1000,0,True)
✅ TestStoryboardProducesCorrectStartTimeFadeInAfterOtherEvents(1000,0,True)
✅ TestStoryboardProducesCorrectStartTimeSimpleAlpha(-1000,-1000)
✅ TestStoryboardProducesCorrectStartTimeSimpleAlpha(-1000,-1000)
✅ TestStoryboardProducesCorrectStartTimeSimpleAlpha(-10000,-10000)
✅ TestStoryboardProducesCorrectStartTimeSimpleAlpha(-10000,-10000)
✅ TestStoryboardProducesCorrectStartTimeSimpleAlpha(0,0)
✅ TestStoryboardProducesCorrectStartTimeSimpleAlpha(0,0)
✅ TestStoryboardProducesCorrectStartTimeSimpleAlpha(1000,0)
✅ TestStoryboardProducesCorrectStartTimeSimpleAlpha(1000,0)
❌ osu.Game.Tests.Visual.Multiplayer.TestSceneMultiSpectatorScreen
✅ TestAudioLeadIn
✅ TestAudioLeadIn
✅ TestConstructor
✅ TestConstructor
✅ TestDelayedStart
✅ TestDelayedStart
✅ TestGameplayRateAdjust
✅ TestGameplayRateAdjust
✅ TestGeneral(1)
✅ TestGeneral(1)
✅ TestGeneral(4)
✅ TestGeneral(4)
✅ TestGeneral(9)
✅ TestGeneral(9)
✅ TestIntroStoryboardElement
✅ TestIntroStoryboardElement
❌ TestMostInSyncUserIsAudioSource
assertOnePlayerNotMuted
✅ TestMostInSyncUserIsAudioSource
✅ TestMultipleStartRequests
✅ TestMultipleStartRequests
✅ TestPlayersCatchUpAfterFallingBehind
✅ TestPlayersCatchUpAfterFallingBehind
✅ TestPlayersContinueWhileOthersBuffer
✅ TestPlayersContinueWhileOthersBuffer
✅ TestPlayersDoNotStartSimultaneouslyIfBufferingForMaximumStartDelay
✅ TestPlayersDoNotStartSimultaneouslyIfBufferingForMaximumStartDelay
✅ TestPlayersLeaveWhileSpectating
✅ TestPlayersLeaveWhileSpectating
✅ TestPlayersMustStartSimultaneously
✅ TestPlayersMustStartSimultaneously
✅ TestSpectatingDuringGameplay
✅ TestSpectatingDuringGameplay
✅ TestSpectatingDuringGameplayWithLateFrames
✅ TestSpectatingDuringGameplayWithLateFrames
✅ TestSpectatorPlayerInteractiveElementsHidden
✅ TestSpectatorPlayerInteractiveElementsHidden
✅ TestTeamDisplay
✅ TestTeamDisplay
✅ TestTeams(16)
✅ TestTeams(16)
✅ TestTeams(2)
✅ TestTeams(2)
✅ TestTimeDoesNotProgressWhileAllPlayersPaused
✅ TestTimeDoesNotProgressWhileAllPlayersPaused
Annotations
Check failure on line 0 in TestResults-Windows-SingleThread.trx
github-actions / Test Results (Windows, SingleThread)
osu.Game.Tests.Visual.Gameplay.TestSceneLeadIn ► TestStoryboardProducesCorrectStartTimeFadeInAfterOtherEvents(-10000,-10000,True)
Failed test found in:
TestResults-Windows-SingleThread.trx
Error:
check first frame time: Expected: -10000.0d +/- 100.0d
But was: -9624.2255000000005d
Off by: -375.77449999999953d
Raw output
check first frame time: Expected: -10000.0d +/- 100.0d
But was: -9624.2255000000005d
Off by: -375.77449999999953d
at osu.Framework.Threading.ScheduledDelegate.RunTaskInternal()
at osu.Framework.Threading.Scheduler.Update()
at osu.Framework.Graphics.Drawable.UpdateSubTree()
at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
at osu.Framework.Platform.GameHost.UpdateFrame()
at osu.Framework.Threading.GameThread.processFrame()
at osu.Framework.Platform.ThreadRunner.RunMainLoop()
at osu.Framework.Platform.GameHost.windowUpdate()
at osu.Framework.Platform.GameHost.Run(Game game)
Check failure on line 0 in TestResults-Windows-SingleThread.trx
github-actions / Test Results (Windows, SingleThread)
osu.Game.Tests.Visual.Gameplay.TestSceneLeadIn ► TestStoryboardProducesCorrectStartTimeFadeInAfterOtherEvents(1000,0,False)
Failed test found in:
TestResults-Windows-SingleThread.trx
Error:
check first frame time: Expected: 0.0d +/- 100.0d
But was: 225.21689999999998d
Off by: -225.21689999999998d
Raw output
check first frame time: Expected: 0.0d +/- 100.0d
But was: 225.21689999999998d
Off by: -225.21689999999998d
at osu.Framework.Threading.ScheduledDelegate.RunTaskInternal()
at osu.Framework.Threading.Scheduler.Update()
at osu.Framework.Graphics.Drawable.UpdateSubTree()
at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
at osu.Framework.Platform.GameHost.UpdateFrame()
at osu.Framework.Threading.GameThread.processFrame()
at osu.Framework.Platform.ThreadRunner.RunMainLoop()
at osu.Framework.Platform.GameHost.windowUpdate()
at osu.Framework.Platform.GameHost.Run(Game game)
Check failure on line 0 in TestResults-Windows-SingleThread.trx
github-actions / Test Results (Windows, SingleThread)
osu.Game.Tests.Visual.Multiplayer.TestSceneMultiSpectatorScreen ► TestMostInSyncUserIsAudioSource
Failed test found in:
TestResults-Windows-SingleThread.trx
Error:
assertOnePlayerNotMuted
Raw output
assertOnePlayerNotMuted
at osu.Framework.Threading.ScheduledDelegate.RunTaskInternal()
at osu.Framework.Threading.Scheduler.Update()
at osu.Framework.Graphics.Drawable.UpdateSubTree()
at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
at osu.Framework.Platform.GameHost.UpdateFrame()
at osu.Framework.Threading.GameThread.processFrame()
at osu.Framework.Platform.ThreadRunner.RunMainLoop()
at osu.Framework.Platform.GameHost.windowUpdate()
at osu.Framework.Platform.GameHost.Run(Game game)
Loading