Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updated PMAX indicator #308

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

updated PMAX indicator #308

wants to merge 1 commit into from

Conversation

amalysh
Copy link

@amalysh amalysh commented Jan 10, 2023

Updated PMAX indicator:

  1. added normalize ATR option
  2. added fill_na option
  3. removed multiple for loops and use only one: speedup

@amalysh
updated PMAX indicator
6592b86 
Updated PMAX indicator:
1. added normalize ATR option
2. added fill_na option
3. removed multiple for loops and use only one: speedup
@xmatthias
Copy link
Member

well it's a PR with conflicts - and a pr that never had CI pass (i do remember that even though the workflow history is gone).
So independent of the change content (good or needs adjustments) - it's not a PR that can be accepted without first fixing conflicts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BlockchainMatrix599 BlockchainMatrix599 BlockchainMatrix599 approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@amalysh @xmatthias @BlockchainMatrix599