switch Merge PR workflow to EKS runners #1459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
demisx
force-pushed
the
1362-switch-merge-pr-to-eks-runners
branch
3 times, most recently
from
c203513
to
a21aaef
Compare
demisx
force-pushed
the
1362-switch-merge-pr-to-eks-runners
branch
from
a21aaef
to
20d307f
Compare
demisx
commented
May 1, 2023
| @@ -65,8 +65,10 @@ jobs: | |||
|
|
|||
| calc-code-coverage: | |||
| name: Merge - Calculate Code Coverage | |||
| # This job currently fails on EKS runners and must be run on standalone until | |||
| # https://www.pivotaltracker.com/story/show/185045668 is resolved. | |||
There was a problem hiding this comment.
Adding this comment, so we remember why this particular job couldn't be switched to the new EKS runners at this point.
saraswatpuneet
approved these changes
May 2, 2023
|
@wilwade Can you approve this one? |
9 tasks
demisx
force-pushed
the
1362-switch-merge-pr-to-eks-runners
branch
9 times, most recently
from
233d9bf
to
ea25dcc
Compare
Codecov Report
@@ Coverage Diff @@
## main #1459 +/- ##
=======================================
Coverage 73.49% 73.49%
=======================================
Files 51 51
Lines 4912 4912
=======================================
Hits 3610 3610
Misses 1302 1302 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
demisx
force-pushed
the
1362-switch-merge-pr-to-eks-runners
branch
from
c1315df
to
cc51881
Compare
demisx
force-pushed
the
1362-switch-merge-pr-to-eks-runners
branch
from
cc51881
to
e67a521
Compare
demisx
commented
May 6, 2023
| @@ -11,15 +11,10 @@ jobs: | |||
| changes: | |||
| name: Determine Changed Files | |||
| runs-on: ubuntu-20.04 | |||
| container: public.ecr.aws/lts/ubuntu:20.04 | |||
| container: ghcr.io/libertydsnp/frequency/ci-base-image | |||
There was a problem hiding this comment.
Taking opportunity to switch container to the new CI base image.
wilwade
approved these changes
May 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
The goal of this PR is switch Merge PR workflow to the new EKS runners.
Part of #1362