Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

signed extension: check stateful storage hash #2133

Closed
wants to merge 7 commits into from

Conversation

aramikm
Copy link
Collaborator

@aramikm aramikm commented Aug 20, 2024

Goal

The goal of this PR is to check the hash for stateful storage transactions and fail early.

Closes #1860

Checklist

  • Unit Tests added?
  • e2e Tests added?
  • Benchmarks added?
  • Spec version incremented?

Copy link

codecov bot commented Aug 20, 2024

Codecov Report

Attention: Patch coverage is 75.86207% with 21 lines in your changes missing coverage. Please review.

Files Patch % Lines
pallets/stateful-storage/src/signed_extension.rs 75.29% 21 Missing ⚠️
Files Coverage Δ
pallets/stateful-storage/src/lib.rs 79.85% <100.00%> (ø)
pallets/stateful-storage/src/signed_extension.rs 75.29% <75.29%> (ø)

... and 1 file with indirect coverage changes

@github-actions github-actions bot added metadata-changed Metadata has changed since the latest full release metadata-version-not-incremented Metadata has changed since the latest full release, but the version has not been incremented labels Aug 20, 2024
@github-actions github-actions bot added metadata-changed Metadata has changed since the latest full release metadata-version-not-incremented Metadata has changed since the latest full release, but the version has not been incremented and removed metadata-changed Metadata has changed since the latest full release metadata-version-not-incremented Metadata has changed since the latest full release, but the version has not been incremented labels Aug 20, 2024
@github-actions github-actions bot added metadata-changed Metadata has changed since the latest full release and removed metadata-changed Metadata has changed since the latest full release metadata-version-not-incremented Metadata has changed since the latest full release, but the version has not been incremented labels Aug 21, 2024
@github-actions github-actions bot added metadata-changed Metadata has changed since the latest full release and removed metadata-changed Metadata has changed since the latest full release labels Aug 21, 2024
@github-actions github-actions bot removed the metadata-changed Metadata has changed since the latest full release label Aug 21, 2024
@aramikm
Copy link
Collaborator Author

aramikm commented Aug 21, 2024

moved to #2137

@aramikm aramikm closed this Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

target_hash RPC Level validation
1 participant