Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

schemas: signature required location type checks #2140

Merged
merged 6 commits into from
Sep 18, 2024
Merged

schemas: signature required location type checks #2140

merged 6 commits into from
Sep 18, 2024

Conversation

aramikm
Copy link
Collaborator

@aramikm aramikm commented Aug 28, 2024

Goal

The goal of this PR is ensure SignatureRequired is only going to be used for Itemized and Paginated locations.

Closes #1874

Checklist

  • Unit Tests added?
  • Spec version incremented?

@aramikm aramikm requested a review from wilwade as a code owner August 28, 2024 21:48
@codecov Codecov
Copy link

codecov bot commented Aug 28, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Files with missing lines Coverage Δ
pallets/schemas/src/lib.rs 82.26% <100.00%> (+0.26%) ⬆️

@github-actions github-actions bot added the metadata-changed Metadata has changed since the latest full release label Aug 28, 2024
enddynayn
enddynayn approved these changes Aug 29, 2024
View reviewed changes
Copy link
Collaborator

@enddynayn enddynayn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 fantastic!

enddynayn
enddynayn reviewed Aug 29, 2024
View reviewed changes
e2e/package-lock.json Outdated Show resolved Hide resolved
@github-actions github-actions bot added metadata-changed Metadata has changed since the latest full release and removed metadata-changed Metadata has changed since the latest full release labels Aug 30, 2024
shannonwells
shannonwells approved these changes Aug 30, 2024
View reviewed changes
Copy link
Collaborator

@shannonwells shannonwells left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@github-actions github-actions bot added metadata-changed Metadata has changed since the latest full release and removed metadata-changed Metadata has changed since the latest full release labels Aug 30, 2024
saraswatpuneet
saraswatpuneet approved these changes Sep 18, 2024
View reviewed changes
Copy link
Collaborator

@saraswatpuneet saraswatpuneet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Waited too long

@github-actions github-actions bot added metadata-changed Metadata has changed since the latest full release and removed metadata-changed Metadata has changed since the latest full release labels Sep 18, 2024
@aramikm aramikm merged commit f86762f into main Sep 18, 2024
27 checks passed
@aramikm aramikm deleted the schema_settings_check branch September 18, 2024 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@enddynayn enddynayn enddynayn approved these changes

@saraswatpuneet saraswatpuneet saraswatpuneet approved these changes

@shannonwells shannonwells shannonwells approved these changes

@wilwade wilwade Awaiting requested review from wilwade wilwade is a code owner

@mattheworris mattheworris Awaiting requested review from mattheworris

@claireolmstead claireolmstead Awaiting requested review from claireolmstead

@JoeCap08055 JoeCap08055 Awaiting requested review from JoeCap08055

Assignees
No one assigned
Labels
metadata-changed Metadata has changed since the latest full release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Schema Creation should Reject SignatureRequired for OnChain and IPFS Payload Locations
4 participants
@aramikm @shannonwells @enddynayn @saraswatpuneet