Display handles are whitespace trimed and collapsed

[wilwade]

Goal

The goal of this PR is to ensure that all new base handles (and thus the resulting display handle) have whitespace trimmed and concatenated

Closes #2148

Discussion

Fairly straightforward. I did benchmark against the collapse crate, and tested some with the versions here: https://stackoverflow.com/questions/71864137/whats-the-ideal-way-to-trim-extra-spaces-from-a-string

In the end this one benchmarked the fastest using a version of this:

#[cfg(test)]
mod tests {
    use super::*;
    use rand::distributions::Alphanumeric;
    use rand::distributions::DistString;
    use test::Bencher;

    #[bench]
    fn bench_one(b: &mut Bencher) {
        let mut rng = rand::thread_rng();
        b.iter(|| {
            trim_and_collapse_whitespace(
                Alphanumeric
                    .sample_string(&mut rng, 20)
                    .to_lowercase()
                    .replace("a", " ")
                    .replace("b", " ")
                    .as_str(),
            );
        });
    }
}

Checklist

• Updated Pallet Readme?
• Design doc(s) updated?
• Unit Tests added?
• Spec version incremented?

[wilwade]

Believe it or not, this appears to be the place that builds the display handle that is saved.

[wilwade]

My formatter really wants to have ; at the end of the line when it is return

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Files with missing lines	Coverage Δ
pallets/handles/src/handles-utils/src/converter.rs	100.00% <100.00%> (ø)
pallets/handles/src/lib.rs	91.48% <100.00%> (+0.03%)	⬆️

[saraswatpuneet]

clean! lgtm

[JoeCap08055]

Looks good--might want to take a pass through the comments/docs and make sure we are consistent in how we refer to this operation: either "collapse" or "consolidate" white space, but NOT "concatenate".

One toolkit I worked with a while back referred to this operation as "simplifying" white space (ie, the combination of trim + collapse)

[mattheworris]

• Read through changes
• Executed tests

🚢 it!