init: static schemas package #2225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wilwade
requested changes
Nov 19, 2024
aramikm
requested review from
wilwade,
shannonwells,
mattheworris,
saraswatpuneet and
JoeCap08055
wilwade
approved these changes
Nov 20, 2024
JoeCap08055
reviewed
Nov 20, 2024
JoeCap08055
reviewed
Nov 20, 2024
Comment on lines
+1
to
+2
| // Only way to silence PolkadotJS API warnings we don't want | ||
| console.warn = () => {}; |
Co-authored-by: Joe Caputo <joseph.caputo@unfinished.com>
JoeCap08055
reviewed
Nov 20, 2024
There was a problem hiding this comment.
Looks great--however I think we're missing a couple of key functions:
- Should have a method that can retrieve all versions of a given schema name
- Should be able to query
<schema.fullname>@latestto get the latest version
Granted, these are easy enough for anyone to do with access to the underlying array, but I think this package should provide those lookups as a convenience.
JoeCap08055
previously requested changes
Nov 20, 2024
mattheworris
approved these changes
Nov 20, 2024
aramikm
dismissed
JoeCap08055’s stale review
Added requested functionality. Have to dismiss it here to be able to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
The goal of this PR is create a new js package for schema name and ID mappings
Closes #2176
Discussion
dsnpschemas from chain. The issue is that currently there is no easy way to get all schema names without providing namespaces. We can get all using raw state but then we would need to scale decode it.