Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add initial protobuf definitions #1

Merged
merged 14 commits into from
Dec 28, 2023
Merged

Add initial protobuf definitions #1

merged 14 commits into from
Dec 28, 2023

Conversation

david-natingga-frequenz
Copy link
Contributor

Add initial protobuf definitions for the Electricity Trading API. The definitions are dependent on some of the common definitions to be added first.

@github-actions github-actions bot added part:docs Affects the documentation part:tests Affects the unit, integration and performance (benchmarks) tests part:tooling Affects the development tooling (CI, deployment, dependency management, etc.) labels Dec 27, 2023
@matthias-wende-frequenz
Copy link
Contributor

matthias-wende-frequenz commented Dec 27, 2023

I've updated the PR and it should be (almost) ready.

For now it's blocked on frequenz-floss/frequenz-api-common#161.
#161 is merged and we are ready to go!

* The google api has been updated to the latest master branch of the
googleapis repository.
* The frequenz common api has been updated to v0.5.3

Signed-off-by: Matthias Wende <matthias.wende@frequenz.com>
@matthias-wende-frequenz matthias-wende-frequenz force-pushed the protobuf branch 3 times, most recently from 94e32fd to f5c26e9 Compare December 28, 2023 12:19
The decimal message is needed as a dependency in order to compile the
api definitions.

Signed-off-by: Matthias Wende <matthias.wende@frequenz.com>
Signed-off-by: Matthias Wende <matthias.wende@frequenz.com>
Signed-off-by: Matthias Wende <matthias.wende@frequenz.com>
Signed-off-by: Matthias Wende <matthias.wende@frequenz.com>
Signed-off-by: Matthias Wende <matthias.wende@frequenz.com>
Signed-off-by: Matthias Wende <matthias.wende@frequenz.com>
Also fixes two typos.
Signed-off-by: Matthias Wende <matthias.wende@frequenz.com>
Signed-off-by: Matthias Wende <matthias.wende@frequenz.com>
Such a section is misleading for an API.

Signed-off-by: Matthias Wende <matthias.wende@frequenz.com>
Also follows proto best practices.

Signed-off-by: Matthias Wende <matthias.wende@frequenz.com>
Signed-off-by: Matthias Wende <matthias.wende@frequenz.com>
Signed-off-by: Matthias Wende <matthias.wende@frequenz.com>
Signed-off-by: Matthias Wende <matthias.wende@frequenz.com>
@matthias-wende-frequenz matthias-wende-frequenz added priority:URGENT Address this immediately or the sky will fall type:enhancement New feature or enhancement visitble to users labels Dec 28, 2023
@camille-bouvy-frequenz camille-bouvy-frequenz merged commit c738c07 into main Dec 28, 2023
@camille-bouvy-frequenz camille-bouvy-frequenz deleted the protobuf branch December 28, 2023 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
part:docs Affects the documentation part:tests Affects the unit, integration and performance (benchmarks) tests part:tooling Affects the development tooling (CI, deployment, dependency management, etc.) priority:URGENT Address this immediately or the sky will fall type:enhancement New feature or enhancement visitble to users
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants