Add unit conversion methods to Energy type #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -118,7 +118,7 @@ def to_pb(self) -> price_pb2.Price: | |||
|
|
|||
| @dataclass(frozen=True) | |||
| class Energy: | |||
| """Represents energy unit in Megawatthours (MWh).""" | |||
| """Represents energy unit in watthours (MWh).""" | |||
There was a problem hiding this comment.
watthours?
There was a problem hiding this comment.
oops typo thanks
Signed-off-by: camille-bouvy-frequenz <camille.bouvy@frequenz.com>
Signed-off-by: camille-bouvy-frequenz <camille.bouvy@frequenz.com>
camille-bouvy-frequenz
force-pushed
the
energy-type
branch
from
b9ad981 to
6f25b32
Compare
matthias-wende-frequenz
approved these changes
Jan 13, 2024
camille-bouvy-frequenz
merged commit e2e84c5
into
frequenz-floss:v0.x.x
15 checks passed
camille-bouvy-frequenz
added a commit
to camille-bouvy-frequenz/frequenz-api-electricity-trading
that referenced
this pull request
Jan 16, 2024
camille-bouvy-frequenz
added a commit
to camille-bouvy-frequenz/frequenz-api-electricity-trading
that referenced
this pull request
Jan 16, 2024
camille-bouvy-frequenz
added a commit
that referenced
this pull request
Jan 18, 2024
Revert #18 Add unit conversion methods to Energy type
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation as described in #17