Add grpcio support to parse_grpc_uri()#54
Merged
llucax merged 2 commits intofrequenz-floss:v0.x.xfrom Jun 3, 2024
Merged
Conversation
github-actions
bot
added
part:docs
llucax
added
scope:breaking-change
Contributor
Author
|
Enabled auto-merge. |
llucax
force-pushed
the
parse_uri-grpcio
branch
3 times, most recently
from
4093c3a to
015078d
Compare
github-actions
bot
added
the
part:tests
This will soon be used to make `parse_grpc_url()` support grpcio too. Signed-off-by: Leandro Lucarella <luca-frequenz@llucax.com>
Now `parse_grpc_uri()` takes the channel type as an extra argument and will create the appropriate type of channel based on this. Signed-off-by: Leandro Lucarella <luca-frequenz@llucax.com>
Marenz
approved these changes
Jun 3, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
parse_grpc_uri()compatible withgrpcio