Add support for AggregatedMetricValue#203
Closed
micaebe wants to merge 2 commits intofrequenz-floss:v0.x.xfrom
Closed
Add support for AggregatedMetricValue#203micaebe wants to merge 2 commits intofrequenz-floss:v0.x.xfrom
micaebe wants to merge 2 commits intofrequenz-floss:v0.x.xfrom
Conversation
cwasicki
reviewed
Jul 8, 2025
Contributor
cwasicki
left a comment
cwasicki
left a comment
There was a problem hiding this comment.
Thanks a lot for the fix! LGTM, small comment to avoid the CI failure. Also needs signing of the commits.
| elif sample.value.HasField("aggregated_metric"): | ||
| value = sample.value.aggregated_metric.avg_value | ||
| else: | ||
| value = math.nan |
Contributor
There was a problem hiding this comment.
This part could be moved into a separate method to avoid the CI failure. In fact this whole class is on the list for refactoring anyway, and this would be a reasonable change.
Contributor
|
Addressed in PR #204 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support to read
AggregatedMetricValue(besidesSimpleMetricValue) insideGenericDataBatch.