Skip to content

Add support for requesting multiple metrics#26

Merged
cwasicki merged 4 commits intofrequenz-floss:v0.x.xfrom
cwasicki:multi
Mar 23, 2024
Merged

Add support for requesting multiple metrics#26
cwasicki merged 4 commits intofrequenz-floss:v0.x.xfrom
cwasicki:multi

Conversation

@cwasicki
Copy link
Contributor

@cwasicki cwasicki commented Mar 22, 2024

This add support to request multiple metrics in a single request. The limitation to query data only from a single component is still in place. Moreover the distinct return types when querying single or multiple metrics is removed.

In addition to that, this turns the example client into a command line tool that can be used to extract data from the reporting API and print it to stdout. Besides option for selecting the data, the service address and the display format can be changed via command line.

@cwasicki cwasicki requested a review from a team as a code owner March 22, 2024 16:57
@github-actions github-actions bot added the part:docs Affects the documentation label Mar 22, 2024
This removes the distinction between querying single and multiple
metrics to simplify the code base.

Signed-off-by: cwasicki <126617870+cwasicki@users.noreply.github.com>
This turns the example client into a command line tool that can be used
to extract data from the reporting API and print it to stdout.

Besides option for selecting the data, the service address and the
display format can be changed via command line.

Signed-off-by: cwasicki <126617870+cwasicki@users.noreply.github.com>
This add support to request multiple metrics in a single request. The
limitation to query data only from a single component is still in place.

Signed-off-by: cwasicki <126617870+cwasicki@users.noreply.github.com>
Copy link

@tiyash-basu-frequenz tiyash-basu-frequenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

Signed-off-by: cwasicki <126617870+cwasicki@users.noreply.github.com>
@cwasicki cwasicki merged commit 90daf45 into frequenz-floss:v0.x.x Mar 23, 2024
@cwasicki cwasicki deleted the multi branch March 23, 2024 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

part:docs Affects the documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants