Skip to content

Remove iterator from function names#33

Merged
cwasicki merged 2 commits intofrequenz-floss:v0.x.xfrom
cwasicki:iter
Apr 19, 2024
Merged

Remove iterator from function names#33
cwasicki merged 2 commits intofrequenz-floss:v0.x.xfrom
cwasicki:iter

Conversation

@cwasicki
Copy link
Contributor

@cwasicki cwasicki commented Apr 12, 2024

Replace iterator in method names to be closer to gRPC names.

Raised here https://github.com/frequenz-floss/frequenz-client-reporting-python/pull/16/files#r1548128616.

Naming might not be final.

FYI @llucax

@cwasicki cwasicki self-assigned this Apr 12, 2024
@cwasicki cwasicki requested a review from a team as a code owner April 12, 2024 11:18
@github-actions github-actions bot added the part:docs Affects the documentation label Apr 12, 2024
@cwasicki cwasicki force-pushed the iter branch 2 times, most recently from 270f3d7 to 62b17ef Compare April 18, 2024 16:17
Signed-off-by: cwasicki <126617870+cwasicki@users.noreply.github.com>
Signed-off-by: cwasicki <126617870+cwasicki@users.noreply.github.com>
Copy link
Contributor

@flora-hofmann-frequenz flora-hofmann-frequenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@cwasicki cwasicki added this pull request to the merge queue Apr 19, 2024
Merged via the queue into frequenz-floss:v0.x.x with commit c9af057 Apr 19, 2024
@cwasicki cwasicki deleted the iter branch April 19, 2024 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

part:docs Affects the documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants