Add BatteryStatus tests to ensure it recovers automatically after issues #522

shsms · 2023-07-19T09:57:27Z

This PR also does:

Improve usability of MockMicrogrid
Update PowerDistributor tests to use MockMicrogrid
And some small bug fixes and code quality improvements

tests/actor/test_battery_status.py

src/frequenz/sdk/actor/power_distributing/_battery_status.py

tests/utils/component_data_wrapper.py

tests/timeseries/mock_microgrid.py

tests/actor/test_battery_pool_status.py

daniel-zullo-frequenz

I have few minor comments to check for, other than that LGTM

These classes were redefining all parameters, and that had the risk of going out of sync with the fields in the base class. This PR ties the wrappers with their base classes, such that it is easy to identify changes to the base classes, without updates to the wrappers. Signed-off-by: Sahas Subramanian <sahas.subramanian@proton.me>

In most component graph configs, batteries would be attached to inverters and the inverters would be meters. But there might be some cases where there are no meters, and we'll have to read data from the inverters. This commit enables such test configs, that can be used in tests that use the MockMicrogrid. Signed-off-by: Sahas Subramanian <sahas.subramanian@proton.me>

This is the grid power test for component configs without a grid side meter, so it will have to read values from the inverter, to calculate the grid power. Signed-off-by: Sahas Subramanian <sahas.subramanian@proton.me>

Signed-off-by: Sahas Subramanian <sahas.subramanian@proton.me>

MockMicrogrid makes it easy to dynamically create component graph configurations to test with, rather than having to use manually written component graphs with the lower level MockMicrogridClient. Signed-off-by: Sahas Subramanian <sahas.subramanian@proton.me>

These are now unused because tests have migrated to use dynamic component graphs provided by MockMicrogrid. Signed-off-by: Sahas Subramanian <sahas.subramanian@proton.me>

Signed-off-by: Sahas Subramanian <sahas.subramanian@proton.me>

Because of the nature of async, it might happen that data is slightly delayed, so a timer event gets triggered, but component data arrives before the timer event arrives, and in such cases, we end up going into a bad state. This issue is resolved in this PR, by checking that the component data is actually late, every time a timer triggers. Signed-off-by: Sahas Subramanian <sahas.subramanian@proton.me>

Signed-off-by: Sahas Subramanian <sahas.subramanian@proton.me>

shsms requested a review from a team as a code owner July 19, 2023 09:57

shsms requested a review from 0o111 July 19, 2023 09:57

github-actions bot added part:tests Affects the unit, integration and performance (benchmarks) tests part:actor Affects an actor ot the actors utilities (decorator, etc.) labels Jul 19, 2023

shsms added this to the v0.23.0 milestone Jul 21, 2023

llucax assigned shsms Jul 25, 2023