Add zero() constructor for Quantities #535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
part:docs
llucax
added
type:enhancement
Marenz
reviewed
Jul 26, 2023
shsms
reviewed
Jul 26, 2023
github-actions
bot
added
part:docs
Having them mutating the objects in-place is not the best option as number are assumed to be immutable in Python. If we make them mutable, then bad things will happen if they are used as default arguments in functions, or if we want to provide a zero singleton for example. We also mention explicitly now that Quantities are immutable. This partially reverts 1043360 (the tests are kept). Signed-off-by: Leandro Lucarella <luca-frequenz@llucax.com>
It is a very common case which becomes very verbose, and it includes unit information that is completely irrelevant (zero is zero in any unit). Signed-off-by: Leandro Lucarella <luca-frequenz@llucax.com>
|
Updated to revert adding the mutable methods and added a test to make sure zero is immutable. |
shsms
approved these changes
Aug 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is a very common case which becomes very verbose, and it includes unit information that is completely irrelevant (zero is zero in any unit).