Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements to the ConfigManagingActor #565

Merged
merged 7 commits into from
Aug 7, 2023

Commits on Aug 7, 2023

  1. Use built-in types for typing

    Signed-off-by: Leandro Lucarella <luca-frequenz@llucax.com>
    llucax committed Aug 7, 2023
    Configuration menu
    Copy the full SHA
    1e9e509 View commit details
    Browse the repository at this point in the history
  2. Improve documentation for ConfigManagingActor

    Signed-off-by: Leandro Lucarella <luca-frequenz@llucax.com>
    llucax committed Aug 7, 2023
    Configuration menu
    Copy the full SHA
    3e0566b View commit details
    Browse the repository at this point in the history
  3. Improve logging for ConfigManagingActor

    The stopped message was removed because it is already emitted by the
    Actor class. Other messages now include the instance information for
    better debugging.
    
    Signed-off-by: Leandro Lucarella <luca-frequenz@llucax.com>
    llucax committed Aug 7, 2023
    Configuration menu
    Copy the full SHA
    2ef482c View commit details
    Browse the repository at this point in the history
  4. Add missing type hints to attributes

    Signed-off-by: Leandro Lucarella <luca-frequenz@llucax.com>
    llucax committed Aug 7, 2023
    Configuration menu
    Copy the full SHA
    6019072 View commit details
    Browse the repository at this point in the history
  5. Rename conf_file to config_path and accept pathlib.Path

    We accept `pathlib.Path` as the `config_path` as it gives more
    flexibility. We also store a `pathlib.Path` internally, so we also don't
    need to keep a copy of the config file directory.
    
    Signed-off-by: Leandro Lucarella <luca-frequenz@llucax.com>
    llucax committed Aug 7, 2023
    Configuration menu
    Copy the full SHA
    36ecb42 View commit details
    Browse the repository at this point in the history
  6. Add clarification about watching the parent directory

    Signed-off-by: Leandro Lucarella <luca-frequenz@llucax.com>
    llucax committed Aug 7, 2023
    Configuration menu
    Copy the full SHA
    f22a5c0 View commit details
    Browse the repository at this point in the history
  7. Use match to process the file watcher events

    We also improve the logging by having a custom message for each type of
    update.
    
    Signed-off-by: Leandro Lucarella <luca-frequenz@llucax.com>
    llucax committed Aug 7, 2023
    Configuration menu
    Copy the full SHA
    3c725e7 View commit details
    Browse the repository at this point in the history