-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Addition of optional metaText details for Feat/select-options #936
Merged
rihansiddhi
merged 31 commits into
freshworks:next
from
harshith-venkatesh-freshworks:feat/select-options
Oct 3, 2024
Merged
Addition of optional metaText details for Feat/select-options #936
rihansiddhi
merged 31 commits into
freshworks:next
from
harshith-venkatesh-freshworks:feat/select-options
Oct 3, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ect option with author details
Hi @rihansiddhi @arvindanta , Reverting the above changes, I am still observing the same set of errors here. |
rihansiddhi
requested changes
Sep 30, 2024
packages/crayons-core/src/components/select-option/select-option.tsx
Outdated
Show resolved
Hide resolved
rihansiddhi
requested changes
Sep 30, 2024
rihansiddhi
requested changes
Sep 30, 2024
packages/crayons-core/src/components/select-option/select-option.tsx
Outdated
Show resolved
Hide resolved
…on.tsx Co-authored-by: rihansiddhi <rihan.siddhi@freshworks.com>
rihansiddhi
reviewed
Oct 1, 2024
packages/crayons-core/src/components/select-option/select-option.e2e.ts
Outdated
Show resolved
Hide resolved
rihansiddhi
approved these changes
Oct 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Kindly address the tests in a subsequent PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist:
How Has This Been Tested?
There is an introduction of new variant in previous build where we had introduced new set of data field called metaText.
Here, in case of select-options as well, we are adding the support conditionally to ensure the metaText details if present is made available in the fw-select which is used to create dynamically in fw-form.