Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: enable date filter to contain maxYear for filters in custom object #954

Merged
merged 3 commits into from
Nov 25, 2024
Merged

fix: enable date filter to contain maxYear for filters in custom object #954

merged 3 commits into from
Nov 25, 2024

Conversation

harshith-venkatesh-freshworks
Copy link
Collaborator

@harshith-venkatesh-freshworks harshith-venkatesh-freshworks commented Nov 21, 2024 •
edited
Loading

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • My commits have standard messages as mentioned in Contributing Guidelines

How Has This Been Tested?

We have added maxYear and minYear for filter conditions as for filters in custom objects, we have possibality of attribute containing dates of similar range that needs to be filtered

@rihansiddhi rihansiddhi merged commit 256b21e into freshworks:next Nov 25, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rihansiddhi rihansiddhi rihansiddhi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@harshith-venkatesh-freshworks @rihansiddhi