Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added support of Triplet Attention #104

Merged
merged 8 commits into from
Nov 4, 2020
Merged

feat: Added support of Triplet Attention #104

merged 8 commits into from
Nov 4, 2020

Conversation

frgfm
Copy link
Owner

@frgfm frgfm commented Nov 4, 2020

This PR adds support of triplet attention, with a modified implementation of https://github.com/LandskapeAI/triplet-attention/blob/master/MODELS/triplet_attention.py.

@frgfm frgfm added topic: documentation Improvements or additions to documentation module: nn ext: tests Related to test labels Nov 4, 2020
@frgfm frgfm added this to the 0.1.4 milestone Nov 4, 2020
@frgfm frgfm self-assigned this Nov 4, 2020
@codecov
Copy link

codecov bot commented Nov 4, 2020

Codecov Report

Merging #104 into master will increase coverage by 0.11%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #104      +/-   ##
==========================================
+ Coverage   90.92%   91.03%   +0.11%     
==========================================
  Files          48       48              
  Lines        2711     2745      +34     
==========================================
+ Hits         2465     2499      +34     
  Misses        246      246              
Impacted Files Coverage Δ
holocron/nn/functional.py 96.55% <100.00%> (+0.04%) ⬆️
holocron/nn/modules/attention.py 100.00% <100.00%> (ø)
holocron/nn/modules/downsample.py 92.75% <100.00%> (+0.69%) ⬆️

@frgfm frgfm merged commit 60b5d22 into master Nov 4, 2020
@frgfm frgfm deleted the triplet-attention branch November 4, 2020 01:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ext: docs ext: tests Related to test module: nn topic: documentation Improvements or additions to documentation type: new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant