Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fixed loss weight buffer #136

Merged
merged 1 commit into from
Jul 28, 2021
Merged

fix: Fixed loss weight buffer #136

merged 1 commit into from
Jul 28, 2021

Conversation

frgfm
Copy link
Owner

@frgfm frgfm commented Jul 28, 2021

This PR fixes the weight registering in loss modules.

@frgfm frgfm added type: bug Something isn't working module: nn labels Jul 28, 2021
@frgfm frgfm added this to the 0.1.4 milestone Jul 28, 2021
@frgfm frgfm self-assigned this Jul 28, 2021
@codecov
Copy link

codecov bot commented Jul 28, 2021

Codecov Report

Merging #136 (a5490d7) into master (afae658) will increase coverage by 0.00%.
The diff coverage is 60.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #136   +/-   ##
=======================================
  Coverage   91.65%   91.65%           
=======================================
  Files          51       51           
  Lines        2887     2889    +2     
=======================================
+ Hits         2646     2648    +2     
  Misses        241      241           
Impacted Files Coverage Δ
holocron/nn/modules/loss.py 93.90% <60.00%> (+0.15%) ⬆️

@frgfm frgfm merged commit e1fed60 into master Jul 28, 2021
@frgfm frgfm deleted the loss-buffer branch July 28, 2021 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module: nn type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant