Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: Fixed typing of TridentNet #141

Merged
merged 2 commits into from
Aug 30, 2021
Merged

style: Fixed typing of TridentNet #141

merged 2 commits into from
Aug 30, 2021

Conversation

frgfm
Copy link
Owner

@frgfm frgfm commented Aug 30, 2021

This PR fixes the typing issue with TridentNet

@frgfm frgfm added type: enhancement New feature or request module: models labels Aug 30, 2021
@frgfm frgfm added this to the 0.1.4 milestone Aug 30, 2021
@frgfm frgfm self-assigned this Aug 30, 2021
@codecov
Copy link

codecov bot commented Aug 30, 2021

Codecov Report

Merging #141 (4bfdc7d) into master (74e4e16) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #141   +/-   ##
=======================================
  Coverage   91.93%   91.93%           
=======================================
  Files          52       52           
  Lines        2989     2989           
=======================================
  Hits         2748     2748           
  Misses        241      241           
Impacted Files Coverage Δ
holocron/models/tridentnet.py 89.47% <100.00%> (ø)
holocron/trainer/core.py 88.29% <100.00%> (ø)

@frgfm frgfm merged commit 69c5a09 into master Aug 30, 2021
@frgfm frgfm deleted the mypy-fix branch August 30, 2021 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant