Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fixed LR Finder plot scaling #147

Merged
merged 2 commits into from
Nov 1, 2021
Merged

fix: Fixed LR Finder plot scaling #147

merged 2 commits into from
Nov 1, 2021

Conversation

frgfm
Copy link
Owner

@frgfm frgfm commented Oct 30, 2021

This PR fixes the plot limits for LR Find. The numpy .argmax method yields a numpy.int64 which does not verify the check isinstance(min_idx, int) so the scaling was off in most cases.

@frgfm frgfm added type: enhancement New feature or request module: trainer labels Oct 30, 2021
@frgfm frgfm added this to the 0.2.0 milestone Oct 30, 2021
@frgfm frgfm self-assigned this Oct 30, 2021
@codecov
Copy link

codecov bot commented Nov 1, 2021

Codecov Report

Merging #147 (b6f6678) into master (db8c5fe) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #147   +/-   ##
=======================================
  Coverage   91.98%   91.98%           
=======================================
  Files          52       52           
  Lines        3007     3007           
=======================================
  Hits         2766     2766           
  Misses        241      241           
Impacted Files Coverage Δ
holocron/trainer/core.py 88.29% <100.00%> (ø)

@frgfm frgfm merged commit bab813f into master Nov 1, 2021
@frgfm frgfm deleted the lrfind-fix branch November 1, 2021 00:43
@frgfm frgfm added type: bug Something isn't working and removed type: enhancement New feature or request labels Jan 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module: trainer type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant