Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Removed functional legacy elements #159

Merged
merged 1 commit into from
Nov 6, 2021
Merged

Conversation

frgfm
Copy link
Owner

@frgfm frgfm commented Nov 6, 2021

This PR removes functional version of radam and ls_cross_entropy

@frgfm frgfm added type: enhancement New feature or request module: nn labels Nov 6, 2021
@frgfm frgfm added this to the 0.2.0 milestone Nov 6, 2021
@frgfm frgfm self-assigned this Nov 6, 2021
@codecov
Copy link

codecov bot commented Nov 6, 2021

Codecov Report

Merging #159 (ae37646) into master (229d90b) will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #159      +/-   ##
==========================================
+ Coverage   92.26%   92.28%   +0.01%     
==========================================
  Files          52       51       -1     
  Lines        3039     2981      -58     
==========================================
- Hits         2804     2751      -53     
+ Misses        235      230       -5     
Impacted Files Coverage Δ
holocron/optim/__init__.py 100.00% <ø> (ø)
holocron/optim/functional.py 82.19% <ø> (-1.68%) ⬇️

@frgfm frgfm merged commit 91704b9 into master Nov 6, 2021
@frgfm frgfm deleted the radam-cleanup branch November 6, 2021 17:56
@frgfm frgfm added type: breaking change and removed type: enhancement New feature or request labels Feb 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant