Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fixed LR Find when loss explodes #169

Merged
merged 1 commit into from
Nov 14, 2021
Merged

fix: Fixed LR Find when loss explodes #169

merged 1 commit into from
Nov 14, 2021

Conversation

frgfm
Copy link
Owner

@frgfm frgfm commented Nov 14, 2021

This PR simply ensures that the LR & loss recorders always have the same length.

@frgfm frgfm added type: enhancement New feature or request module: trainer labels Nov 14, 2021
@frgfm frgfm added this to the 0.2.0 milestone Nov 14, 2021
@frgfm frgfm self-assigned this Nov 14, 2021
@codecov
Copy link

codecov bot commented Nov 14, 2021

Codecov Report

Merging #169 (d831c1b) into master (2280ea3) will increase coverage by 0.00%.
The diff coverage is 25.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #169   +/-   ##
=======================================
  Coverage   93.80%   93.80%           
=======================================
  Files          51       51           
  Lines        2985     2988    +3     
=======================================
+ Hits         2800     2803    +3     
  Misses        185      185           
Impacted Files Coverage Δ
holocron/trainer/core.py 90.83% <25.00%> (+0.07%) ⬆️

@frgfm frgfm merged commit d310c1a into master Nov 14, 2021
@frgfm frgfm deleted the lr-find branch November 14, 2021 14:28
@frgfm frgfm added type: bug Something isn't working and removed type: enhancement New feature or request labels Jan 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module: trainer type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant