Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Refactored holocron.trainer #173

Merged
merged 5 commits into from
Nov 14, 2021
Merged

refactor: Refactored holocron.trainer #173

merged 5 commits into from
Nov 14, 2021

Conversation

frgfm
Copy link
Owner

@frgfm frgfm commented Nov 14, 2021

This PR introduces the following modifications:

  • raises a ValueError in check_setup when the loss becomes infinite or NaN
  • split implementations of Trainer by task

@frgfm frgfm added type: enhancement New feature or request module: trainer labels Nov 14, 2021
@frgfm frgfm added this to the 0.2.0 milestone Nov 14, 2021
@frgfm frgfm self-assigned this Nov 14, 2021
@codecov
Copy link

codecov bot commented Nov 14, 2021

Codecov Report

Merging #173 (b36feb0) into master (f7c50eb) will increase coverage by 0.00%.
The diff coverage is 91.52%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #173   +/-   ##
=======================================
  Coverage   93.82%   93.82%           
=======================================
  Files          51       54    +3     
  Lines        2994     3012   +18     
=======================================
+ Hits         2809     2826   +17     
- Misses        185      186    +1     
Impacted Files Coverage Δ
holocron/trainer/core.py 90.25% <80.00%> (-0.58%) ⬇️
holocron/trainer/detection.py 88.15% <88.15%> (ø)
holocron/trainer/classification.py 91.07% <91.07%> (ø)
holocron/trainer/__init__.py 100.00% <100.00%> (ø)
holocron/trainer/segmentation.py 100.00% <100.00%> (ø)

@frgfm frgfm merged commit 08df50c into master Nov 14, 2021
@frgfm frgfm deleted the trainer-refactor branch November 14, 2021 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant