Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fixed LR find plotting #180

Merged
merged 1 commit into from
Dec 2, 2021
Merged

fix: Fixed LR find plotting #180

merged 1 commit into from
Dec 2, 2021

Conversation

frgfm
Copy link
Owner

@frgfm frgfm commented Dec 2, 2021

This PR simply fixes LR plotting in the rare case where the minimum loss is reached on the first iteration.

@frgfm frgfm added type: enhancement New feature or request module: trainer labels Dec 2, 2021
@frgfm frgfm added this to the 0.2.0 milestone Dec 2, 2021
@frgfm frgfm self-assigned this Dec 2, 2021
@codecov
Copy link

codecov bot commented Dec 2, 2021

Codecov Report

Merging #180 (e1054d4) into master (edcb146) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #180   +/-   ##
=======================================
  Coverage   93.83%   93.83%           
=======================================
  Files          54       54           
  Lines        3017     3017           
=======================================
  Hits         2831     2831           
  Misses        186      186           
Impacted Files Coverage Δ
holocron/trainer/core.py 90.35% <100.00%> (ø)

@frgfm frgfm merged commit ea538d8 into master Dec 2, 2021
@frgfm frgfm deleted the trainer-fix branch December 2, 2021 22:33
@frgfm frgfm added type: bug Something isn't working and removed type: enhancement New feature or request labels Jan 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module: trainer type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant