Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fixed multiple detection training & model issues #182

Merged
merged 17 commits into from
Dec 3, 2021
Merged

Conversation

frgfm
Copy link
Owner

@frgfm frgfm commented Dec 3, 2021

This PR introduces the following modifications:

  • refactored loss weighting of YOLO
  • fixed loss weight, anchor scaling & head initialization of YOLOv2
  • fixed classification loss and added contribution ignoring to YOLOv4
  • adds feature extraction possibility to DarknetV3
  • adds nan tolerance to trainer
  • refactored metric printing for detection trainer
  • fixed torchvision compatibility of detection training

@frgfm frgfm added this to the 0.2.0 milestone Dec 3, 2021
@frgfm frgfm self-assigned this Dec 3, 2021
@codecov
Copy link

codecov bot commented Dec 3, 2021

Codecov Report

Merging #182 (3eae9bd) into master (10106c3) will decrease coverage by 0.33%.
The diff coverage is 75.51%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #182      +/-   ##
==========================================
- Coverage   93.83%   93.49%   -0.34%     
==========================================
  Files          54       54              
  Lines        3019     3046      +27     
==========================================
+ Hits         2833     2848      +15     
- Misses        186      198      +12     
Impacted Files Coverage Δ
holocron/models/darknetv3.py 84.74% <35.71%> (-15.26%) ⬇️
holocron/trainer/core.py 89.26% <50.00%> (-1.19%) ⬇️
holocron/models/detection/yolo.py 98.07% <100.00%> (+0.02%) ⬆️
holocron/models/detection/yolov2.py 98.83% <100.00%> (-0.03%) ⬇️
holocron/models/detection/yolov4.py 97.67% <100.00%> (+0.05%) ⬆️
holocron/trainer/detection.py 88.60% <100.00%> (+0.44%) ⬆️

@frgfm frgfm merged commit 36e0383 into master Dec 3, 2021
@frgfm frgfm deleted the obj-det branch December 3, 2021 14:34
@frgfm
Copy link
Owner Author

frgfm commented Dec 3, 2021

cf. #110

@frgfm frgfm added bug Something isn't working topic: detection and removed type: improvement New feature or request labels Jan 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant