Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Removed contiguous params since torch>=1.7.0 includes it #183

Merged
merged 4 commits into from
Dec 25, 2021

Conversation

frgfm
Copy link
Owner

@frgfm frgfm commented Dec 25, 2021

This PR introduces the following modifications:

  • removes the dependency of contiguous params now that PyTorch includes it
  • updates dependencies

@frgfm frgfm added topic: build Related to build and installation module: trainer labels Dec 25, 2021
@frgfm frgfm added this to the 0.2.0 milestone Dec 25, 2021
@frgfm frgfm self-assigned this Dec 25, 2021
@codecov
Copy link

codecov bot commented Dec 25, 2021

Codecov Report

Merging #183 (01b63a5) into master (36e0383) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #183      +/-   ##
==========================================
- Coverage   93.49%   93.49%   -0.01%     
==========================================
  Files          54       54              
  Lines        3046     3043       -3     
==========================================
- Hits         2848     2845       -3     
  Misses        198      198              
Impacted Files Coverage Δ
holocron/trainer/core.py 89.10% <100.00%> (-0.16%) ⬇️

@frgfm frgfm merged commit 44f1168 into master Dec 25, 2021
@frgfm frgfm deleted the contiguous branch December 25, 2021 15:56
@frgfm frgfm added the type: enhancement New feature or request label Jan 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module: trainer topic: build Related to build and installation type: enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant