Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fixed Mixup for binary & one-hot targets #225

Merged
merged 3 commits into from
Jul 16, 2022
Merged

fix: Fixed Mixup for binary & one-hot targets #225

merged 3 commits into from
Jul 16, 2022

Conversation

frgfm
Copy link
Owner

@frgfm frgfm commented Jul 16, 2022

This PR introduces the following modifications:

  • fixes the arg passing of the mixup alpha to the training script
  • fixes support for one-hot and binary targets
  • extends unittests

@frgfm frgfm added type: bug Something isn't working module: utils ext: tests Related to test ext: references labels Jul 16, 2022
@frgfm frgfm added this to the 0.2.1 milestone Jul 16, 2022
@frgfm frgfm self-assigned this Jul 16, 2022
@frgfm frgfm mentioned this pull request Jul 16, 2022
3 tasks
@codecov
Copy link

codecov bot commented Jul 16, 2022

Codecov Report

Merging #225 (622dcf7) into main (89e8aee) will increase coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head 622dcf7 differs from pull request most recent head eb8ad82. Consider uploading reports for the commit eb8ad82 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #225      +/-   ##
==========================================
+ Coverage   93.50%   93.51%   +0.01%     
==========================================
  Files          56       56              
  Lines        3127     3132       +5     
==========================================
+ Hits         2924     2929       +5     
  Misses        203      203              
Impacted Files Coverage Δ
holocron/utils/data/collate.py 100.00% <100.00%> (ø)

@frgfm frgfm force-pushed the mixup branch 2 times, most recently from 622dcf7 to eb8ad82 Compare July 16, 2022 14:06
@frgfm frgfm merged commit 49125c2 into main Jul 16, 2022
@frgfm frgfm deleted the mixup branch July 16, 2022 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ext: references ext: tests Related to test module: utils type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant