Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes dockerhub push and precommit CI job #292

Merged
merged 2 commits into from
Jan 28, 2024
Merged

Fixes dockerhub push and precommit CI job #292

merged 2 commits into from
Jan 28, 2024

Conversation

frgfm
Copy link
Owner

@frgfm frgfm commented Jan 28, 2024

This PR fixes two issues with the CI:

  • the build of the docker for dockerhub push was exporting the requirements.txt to the wrong location
  • the precommit hook job was run on the main branch which caused it to fail because of the branch guard

@frgfm frgfm added bug Something isn't working ext: ci labels Jan 28, 2024
@frgfm frgfm added this to the 0.2.2 milestone Jan 28, 2024
@frgfm frgfm self-assigned this Jan 28, 2024
@github-actions github-actions bot removed the ext: ci label Jan 28, 2024
@frgfm frgfm merged commit 9418c50 into main Jan 28, 2024
27 of 28 checks passed
@frgfm frgfm deleted the ci-fix branch January 28, 2024 14:14
@github-actions GitHub Actions
Copy link

Hey @frgfm 👋
You merged this PR, but it is not correctly labeled. The list of valid labels is available at https://github.com/frgfm/Holocron/blob/main/.github/verify_labels.py

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@frgfm frgfm

Labels
bug Something isn't working
Projects
None yet
Milestone
0.2.2
Development

Successfully merging this pull request may close these issues.
1 participant
@frgfm