Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fixed compatibility with PyTorch 1.5.1 #49

Merged
merged 3 commits into from
Jun 30, 2020
Merged

fix: Fixed compatibility with PyTorch 1.5.1 #49

merged 3 commits into from
Jun 30, 2020

Conversation

frgfm
Copy link
Owner

@frgfm frgfm commented Jun 30, 2020

This PR fixes compatibility with the latest pytorch version by:

  • updating convolution attribute name
  • updating pytorch minimum version requirement

@frgfm frgfm added type: bug Something isn't working module: nn topic: build Related to build and installation labels Jun 30, 2020
@frgfm frgfm added this to the 0.1.2 milestone Jun 30, 2020
@frgfm frgfm self-assigned this Jun 30, 2020
@codecov
Copy link

codecov bot commented Jun 30, 2020

Codecov Report

Merging #49 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #49   +/-   ##
=======================================
  Coverage   85.36%   85.36%           
=======================================
  Files          29       29           
  Lines        1524     1524           
=======================================
  Hits         1301     1301           
  Misses        223      223           
Impacted Files Coverage Δ
holocron/nn/modules/conv.py 100.00% <100.00%> (ø)

@frgfm frgfm merged commit 6cacc3c into master Jun 30, 2020
@frgfm frgfm deleted the torch-compat branch June 30, 2020 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module: nn topic: build Related to build and installation type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant