Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added implementation of Pyramidal convolution #66

Merged
merged 27 commits into from
Jul 24, 2020
Merged

feat: Added implementation of Pyramidal convolution #66

merged 27 commits into from
Jul 24, 2020

Conversation

frgfm
Copy link
Owner

@frgfm frgfm commented Jul 24, 2020

This PR adds support of pyramidal convolutions by:

  • adding PyConv2d implementation
  • updating unittests
  • updating documentation
  • updating README

@frgfm frgfm added topic: documentation Improvements or additions to documentation type: enhancement New feature or request module: nn ext: tests Related to test labels Jul 24, 2020
@frgfm frgfm added this to the 0.1.3 milestone Jul 24, 2020
@frgfm frgfm self-assigned this Jul 24, 2020
@codecov
Copy link

codecov bot commented Jul 24, 2020

Codecov Report

Merging #66 into master will increase coverage by 0.13%.
The diff coverage is 94.52%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #66      +/-   ##
==========================================
+ Coverage   88.80%   88.93%   +0.13%     
==========================================
  Files          34       35       +1     
  Lines        1759     1817      +58     
==========================================
+ Hits         1562     1616      +54     
- Misses        197      201       +4     
Impacted Files Coverage Δ
holocron/models/res2net.py 92.72% <ø> (ø)
holocron/models/pyconvresnet.py 93.33% <93.33%> (ø)
holocron/models/resnet.py 94.11% <95.23%> (-0.53%) ⬇️
holocron/nn/modules/conv.py 98.68% <95.23%> (-1.32%) ⬇️
holocron/models/__init__.py 100.00% <100.00%> (ø)

@frgfm frgfm merged commit f2e1e8c into master Jul 24, 2020
@frgfm frgfm deleted the pyconv branch July 24, 2020 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ext: tests Related to test module: nn topic: documentation Improvements or additions to documentation type: enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant