Expression presets refactor #446
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great, I will have a look today and try to adapt my PR. 😄 |
|
I can merge this into your PR if needed, or whatever makes things easier. |
Yes, please, merge it here so that I can continue. It will have to be tomorrow as I'm having some family activities I wasn't aware of today... |
Done.
No rush, family first :) |
|
Thanks! BTW, if you have time and feel like advancing in this regard you can push anything you want... |
|
I will take a look later today or tomorrow. Closing this PR as it has been merged into #441 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So, this is a refactor of the existing expressions presets, the first implementation was not good enough. This change is needed before we can add PR #441 (that needs to adapt to this).
@pgilfernandez:
You access the presets class through
eSettings::sInstance->fExpressions.I think everything needed for your PR is supported, see
core/Expressions/expressionpresets.h. I can help adapt.