Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minimum changes to prevent deprecated messages in PHP 8.1 #71

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mmenavas
Copy link

Overview

This PR adds return types to the methods in src/Table.php that override the Iterator class. This is necessary because PHP 8.1 requires "overriding methods to declare a compatible return type".

Fixes #70.


Please preserve this line to notify @courtney-miles (lead of this repository)

@mmenavas mmenavas mentioned this pull request Feb 22, 2023
@courtney-miles
Copy link
Collaborator

The tests are failing, but not due to your changes.

Give me the weekend and I will modify the Github Actions to fix the issues.

@dafeder
Copy link

dafeder commented Mar 21, 2023

Hi @courtney-miles @mmenavas - hoping to use this library in a project soon and wondering where things stand with PHP 8.1 - happy to help if I can.

@mmenavas
Copy link
Author

Hi @courtney-miles @mmenavas - hoping to use this library in a project soon and wondering where things stand with PHP 8.1 - happy to help if I can.

Hi @dafeder! Once this PR is merged, we'll be compatible with PHP 8.1 and 8.2.

@mmenavas
Copy link
Author

@courtney-miles Since the changes on this PR will require dropping support for earlier versions of PHP (PHP <= 8.0), would it be possible to maintain a 1.x version and a 2.x version where the former will continue to support older versions of PHP and the latter 8.1+?

@dafeder
Copy link

dafeder commented Mar 21, 2024

It appears this PR is no longer needed as of 1.2.0 release?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PHP 8.1
3 participants