Fix Windows Build #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
January 5, 2017 14:04
There is a usage of S_ISLNK in check_rc_sys.c, which breaks the linking on Windows since this functionality isn't availble on Windows. This commit adds a compile time check for a WIN32 platform and removes the code if necessary.
This commit fixes the Windows build again. The mingw headers (https://github.com/Alexpux/mingw-w64/blob/master/mingw-w64-headers/crt/_mingw_secapi.h) check if the MINGW_HAS_SECURE_API define is 1, so just defining it isn't enough; this will result in a compile-time error. This commit defines the define to 1 instead of nothing.
This commit adds Windows-specific build output to the .gitignore file, since the current one causes the source tree to be polluted with build output.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the following Windows-related build issues:
S_ISLNK usage
S_ISLNKisn't a supported call on Windows due to the lack of filesystem links like they exist on Unix-based systems. Other parts of the code properly check if WIN32 is defined, however, one piece was overlooked. This is fixed in one of the commits in this PR.MINGW_HAS_SECURE_API Incorrectly Used
The
MINGW_HAS_SECURE_APIwas used incorrectly and broke the Windows build - the correct usage is to define this to '1' instead of just defining it, as evident in the mingw headers.Add Windows-specific output to .gitignore
Some of the build output files aren't added to the .gitignore, causing a potential source tree pollution when committing to the repository. Most notably, there was no exclusion for
*.exeand*.dllfiles, while there was an exclusion for.sofiles. This discrepancy has been corrected.