Merge pull request #53 from friendlycart/fix-order-discounter-shippin…

…g-rate-discounts Order Discounter: Create valid shipping rate discounts
friendlycart · Oct 25, 2023 · 971641c · 971641c
2 parents 9949557 + 021e1f9
commit 971641c
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 2 deletions.
diff --git a/app/models/solidus_friendly_promotions/order_discounter.rb b/app/models/solidus_friendly_promotions/order_discounter.rb
@@ -19,10 +19,11 @@ def call
 
       discountable_order.shipments.flat_map(&:shipping_rates).each do |shipping_rate|
         shipping_rate.discounts = shipping_rate.current_discounts.map do |discount|
-          SolidusFriendlyPromotions::ShippingRateDiscount.new(
+          SolidusFriendlyPromotions::ShippingRateDiscount.create!(
             shipping_rate: shipping_rate,
             amount: discount.amount,
-            label: discount.label
+            label: discount.label,
+            promotion_action: discount.source
           )
         end
       end

diff --git a/spec/models/solidus_friendly_promotions/order_discounter_spec.rb b/spec/models/solidus_friendly_promotions/order_discounter_spec.rb
@@ -92,4 +92,15 @@
       end
     end
   end
+
+  context "adjusting shipping rates" do
+    let!(:promotion) { create(:friendly_promotion, actions: [shipment_action], apply_automatically: true) }
+    let(:shipment_action) { SolidusFriendlyPromotions::Actions::AdjustShipment.new(calculator: fifty_percent) }
+    let(:fifty_percent) { SolidusFriendlyPromotions::Calculators::Percent.new(preferred_percent: 50) }
+    let(:order) { create(:order_with_line_items) }
+
+    it "creates shipping rate discounts" do
+      expect { subject.call }.to change { SolidusFriendlyPromotions::ShippingRateDiscount.count }
+    end
+  end
 end