Actually destroy promotion actions

There's no need for soft-delete on promotion actions, now that we have soft-delete on promotions.
friendlycart · Jan 25, 2024 · c00aa0d · c00aa0d
1 parent 4f29bcb
commit c00aa0d
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 2 deletions.
diff --git a/app/controllers/solidus_friendly_promotions/admin/promotion_actions_controller.rb b/app/controllers/solidus_friendly_promotions/admin/promotion_actions_controller.rb
@@ -53,7 +53,7 @@ def update
 
       def destroy
         @promotion_action = @promotion.actions.find(params[:id])
-        if @promotion_action.discard
+        if @promotion_action.destroy
           flash[:success] =
             t("spree.successfully_removed", resource: SolidusFriendlyPromotions::PromotionAction.model_name.human)
         end

diff --git a/app/models/solidus_friendly_promotions/promotion_action.rb b/app/models/solidus_friendly_promotions/promotion_action.rb
@@ -9,7 +9,6 @@ module SolidusFriendlyPromotions
   # by an event and determined to be eligible.
   class PromotionAction < Spree::Base
     include Spree::Preferences::Persistable
-    include Spree::SoftDeletable
     include Spree::CalculatedAdjustments
     include Spree::AdjustmentSource
     before_destroy :remove_adjustments_from_incomplete_orders