Use different path for friendly promotions #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For the transition process between the two promotion systems, we want the admins to still have access to the legacy promotions. Prior to this commit, this access was thwarted as we used the exact same paths as core Solidus. This adds an extra `friendly/` to the path, so that the paths can be distinguished. This in turn revealed we have to use the right routing proxy for the promotions controller, otherwise we'd be sent to actions in the Solidus world.
This commit isn't super clear cut but really small: It adds a link to the top of the promotions index to the legacy Solidus promotions overview, and it also switches out some of the uses of the legacy system for our system.
mamhoff
force-pushed
the
use-different-path-for-friendly-promotions
branch
from
b5ba4be to
e3fb85a
Compare
The controller code we were using relied on a patch to Solidus[1] that will only be released with Solidus 4.2. We want to be compatible with Solidus 4 though, so we're incorporating that patch into our own BaseController and use that instead of Solidus' ResourceController. [1] solidusio/solidus#5219
mamhoff
force-pushed
the
use-different-path-for-friendly-promotions
branch
from
cd0556f to
f47f8b9
Compare
|
There are a few places in the views where the spree.___path is being used instead of the solidus_friendly_promotions.___path that cause 404s or unexpected navigations. admin/promotion_rules/new.html.erb |
There were many references to the promotion system in solidus core in our views folder still. This commit changes them.
mamhoff
added a commit
that referenced
this pull request
Jul 1, 2024
…dly-promotions Use different path for friendly promotions
mamhoff
added a commit
that referenced
this pull request
Oct 25, 2024
…dly-promotions Use different path for friendly promotions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.