Allow destroying promotions #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, promotions cannot be destroyed as soon as the have dependent records. This sets `dependent: :destroy` on all important relations except for `actions`, which are soft-deletable, and thus need to be nullified instead. Alternatively, we could make all tables soft-deleteable, which would be better for auditing. If a promotion gets applied, and we have an adjustment with a promotion action as its source, and then we delete the promotion action's promotion, we will end up with an "orphan" promotion action. Promotion actions need to be soft-deleteable, because if they are deleted, they might nullify - or worse - delete adjustments on orders.
davecandlescience
approved these changes
Oct 12, 2023
mamhoff
added a commit
that referenced
this pull request
Jul 1, 2024
…omotion-ids Allow destroying promotions
mamhoff
added a commit
that referenced
this pull request
Oct 25, 2024
…omotion-ids Allow destroying promotions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, promotions cannot be destroyed as soon as the have dependent records. This sets
dependent: :destroyon all important relations except foractions, which are soft-deletable, and thus need to be nullified instead.Alternatively, we could make all tables soft-deleteable, which would be better for auditing. If a promotion gets applied, and we have an adjustment with a promotion action as its source, and then we delete the promotion action's promotion, we will end up with an "orphan" promotion action.
Promotion actions need to be soft-deleteable, because if they are deleted, they might nullify - or worse - delete adjustments on orders.